Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use features for selected module resolution rather than all features … #47007

Merged

Conversation

weswigham
Copy link
Member

…for type reference directives, since they can add restrictions to resolutions (eg, exports that don't contain a types resolution and no adjacent declaration files to the js ones blocking use of a top-level types field). This should prevent the new module resolution features from affecting people who don't opt-in to them via the new module modes (though I'm pleased with how quickly it seems some of the affected packages reacted to add a types entry to their exports!).

Fixes #46860

cc @DanielRosenwasser because I imagine you'll want to backport this to 4.5

…for type reference directives, since they can add restrictions to resolutions
@andrewbranch
Copy link
Member

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 3, 2021

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at 48b9027. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I've opened #47016 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Dec 3, 2021
Component commits:
48b9027 Use features for selected module resolution rather than all features for type reference directives, since they can add restrictions to resolutions
@weswigham weswigham merged commit 97a7901 into microsoft:main Dec 4, 2021
DanielRosenwasser pushed a commit that referenced this pull request Dec 7, 2021
…e-4.5 (#47016)

* Cherry-pick PR #47007 into release-4.5

Component commits:
48b9027 Use features for selected module resolution rather than all features for type reference directives, since they can add restrictions to resolutions

* Update baselines for error in stable release versions

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
Co-authored-by: Andrew Branch <andrew@wheream.io>
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
…for type reference directives, since they can add restrictions to resolutions (microsoft#47007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
5 participants