Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit package.json realpath lookup to only successful resolutions #46209

Merged

Conversation

weswigham
Copy link
Member

To test if this is a possible fix for #46204

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 4, 2021
@weswigham
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 4, 2021

Heya @weswigham, I've started to run the tarball bundle task on this PR at 2286798. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 4, 2021

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/112410/artifacts?artifactName=tgz&fileId=214D9C3AF8DB7A4283A82357B806CF870FEF7A8CB13592C6EA7397FB5B3F47D902&fileName=/typescript-4.5.0-insiders.20211004.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.5.0-pr-46209-2".;

@weswigham
Copy link
Member Author

@amcasey 's testing shows this to be a pretty significant perf improvement (over the other PR, too), so I'm going to merge this~

@weswigham weswigham merged commit a0cf126 into microsoft:main Oct 5, 2021
@MLoughry
Copy link

MLoughry commented Oct 5, 2021

@weswigham Testing this change, it's about ~55% faster (~35% less build time) than 4.3.5, which is itself is >2x faster than 4.4.3. Is there a way to integrate this into a 4.4.4 release?

@weswigham
Copy link
Member Author

@DanielRosenwasser would be the one to ask~

@andrewbranch
Copy link
Member

Will discuss with @DanielRosenwasser shortly.

@typescript-bot cherry-pick this to release-4.4

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 5, 2021

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.4 on this PR at 2286798. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I've opened #46230 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Oct 5, 2021
Component commits:
2286798 Limit package.json realpath lookup to only successful resolutions
DanielRosenwasser pushed a commit that referenced this pull request Oct 6, 2021
Component commits:
2286798 Limit package.json realpath lookup to only successful resolutions

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants