Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup around inlay hints types to get more-precise checking. #45391

Merged
merged 2 commits into from Aug 23, 2021

Conversation

DanielRosenwasser
Copy link
Member

Right now, inlay hints incorrectly report that their kind might be optional. We also don't validate that the response has the shape that we're promising, so this PR ensures that we get at least some checking there.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 10, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@sandersn sandersn added this to Not started in PR Backlog Aug 19, 2021
@sandersn sandersn added the Housekeeping Housekeeping PRs label Aug 19, 2021
@sandersn sandersn moved this from Not started to Waiting on reviewers in PR Backlog Aug 19, 2021
@sandersn
Copy link
Member

@DanielRosenwasser does this need to go into 4.4?

@DanielRosenwasser
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.4

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 21, 2021

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.4 on this PR at a2cefc5. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #45529 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 21, 2021
Component commits:
a2cefc5 Some cleanup around inlay hints types to get more-precise checking.
@DanielRosenwasser DanielRosenwasser merged commit af54990 into main Aug 23, 2021
PR Backlog automation moved this from Waiting on reviewers to Done Aug 23, 2021
@DanielRosenwasser DanielRosenwasser deleted the inlayHintsTypeCleanup branch August 23, 2021 23:15
DanielRosenwasser added a commit that referenced this pull request Aug 23, 2021
…45391)

* Some cleanup around inlay hints types to get more-precise checking.

* Update Baselines and/or Applied Lint Fixes

Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
BobobUnicorn pushed a commit to BobobUnicorn/TypeScript that referenced this pull request Oct 24, 2021
…icrosoft#45391)

* Some cleanup around inlay hints types to get more-precise checking.

* Update Baselines and/or Applied Lint Fixes

Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug Housekeeping Housekeeping PRs
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants