Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unintended 'as const' name lookup error #44311

Merged
merged 2 commits into from May 28, 2021
Merged

Fix unintended 'as const' name lookup error #44311

merged 2 commits into from May 28, 2021

Conversation

ahejlsberg
Copy link
Member

Fixes #44292.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 27, 2021
@ahejlsberg ahejlsberg merged commit 9aa50d6 into master May 28, 2021
@ahejlsberg ahejlsberg deleted the fix44292 branch May 28, 2021 00:23
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.3

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 1, 2021 •
edited

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.3 on this PR at e607388. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.3 manually.

DanielRosenwasser pushed a commit that referenced this pull request Jun 1, 2021
@ahejlsberg @DanielRosenwasser
Fix unintended 'as const' name lookup error (#44311)
8d985d8 
* Fix logic for methods in isTypeParameterPossiblyReferenced

* Add regression tests
@DanielRosenwasser DanielRosenwasser mentioned this pull request Jun 1, 2021
Merged
DanielRosenwasser added a commit that referenced this pull request Jun 1, 2021
@DanielRosenwasser @ahejlsberg
Fix unintended 'as const' name lookup error (#44311) (#44370)
e425f57 
* Fix logic for methods in isTypeParameterPossiblyReferenced

* Add regression tests

Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.3: as const looking for the identifier const in a generic class
4 participants
@ahejlsberg @DanielRosenwasser @typescript-bot @RyanCavanaugh