Don't use _fs.realpathSync.native on windows, a semi-revert of #41292 #43348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
j-oliveras
reviewed
Mar 23, 2021
amcasey
reviewed
Mar 23, 2021
amcasey
reviewed
Mar 23, 2021
RyanCavanaugh
approved these changes
Mar 23, 2021
sheetalkamat
approved these changes
Mar 23, 2021
amcasey
approved these changes
Mar 23, 2021
DanielRosenwasser
approved these changes
Mar 24, 2021
amcasey
pushed a commit
to amcasey/TypeScript
that referenced
this pull request
Mar 25, 2021
…oft#41292 (microsoft#43348) We're planning a real fix for TS 4.3, but port the workaround from 4.2 so the beta doesn't have this bug. (cherry picked from commit e462dfa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch hotfix for #43105 reverting #41292
Roughly:
realpathSync.nativereturns uppercased drive labels on Windows which differs fromrealpathSync. without the native suffix.This triggers at least one or two bugs further down the line (e.g. #43342 ) and doing a lot of symlink work assuming maybe
c:/x/y/z.tsis a symlink toC:/x/y/z.ts, that code crashes because it assumes you'd never pass matching paths to the symlink guessing codepaths.4.3 can get a more thorough fix which ideally should keep
realpathSync.native