Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addImplementationSuccessElaboration admits declarations with no symbol #41758

Merged
merged 1 commit into from Dec 1, 2020
Merged

addImplementationSuccessElaboration admits declarations with no symbol #41758

merged 1 commit into from Dec 1, 2020

Conversation

weswigham
Copy link
Member

shakes fist Our imprecise type of Declaration.symbol leads to a bug yet again!

Fixes #41616

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 1, 2020
@weswigham
Copy link
Member Author

Github actions seems to be having some internal errors and builds are cancelling/rescheduling, but devops is reporting green, so I'll merge. Based on the associated issue's milestone, I'll also ask @typescript-bot cherry-pick this into release-4.1

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 1, 2020 •
edited

Heya @weswigham, I've started to run the task to cherry-pick this into release-4.1 on this PR at 0d61b14. You can monitor the build here.

@weswigham weswigham merged commit 2a3f550 into microsoft:master Dec 1, 2020
@typescript-bot
Copy link
Collaborator

Hey @weswigham, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.1 manually.

weswigham added a commit to weswigham/TypeScript that referenced this pull request Dec 1, 2020
@weswigham
addImplementationSuccessElaboration admits declarations with no symbol (
07d56fb 
microsoft#41758)
@weswigham weswigham mentioned this pull request Dec 1, 2020
Closed
@weswigham
Copy link
Member Author

@typescript-bot cherry-pick this into release-4.1

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 7, 2020 •
edited

Heya @weswigham, I've started to run the task to cherry-pick this into release-4.1 on this PR at 0d61b14. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Dec 7, 2020
Merged
@typescript-bot
Copy link
Collaborator

Hey @weswigham, I've opened #41862 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Dec 7, 2020
@weswigham
Cherry-pick PR microsoft#41758 into release-4.1
ca7fe57 
Component commits:
0d61b14 addImplementationSuccessElaboration admits declarations with no symbol
@remcohaszing remcohaszing mentioned this pull request Dec 9, 2020
Closed
DanielRosenwasser pushed a commit that referenced this pull request Dec 9, 2020
@typescript-bot @weswigham
Cherry-pick PR #41758 into release-4.1 (#41862)
1e9518c 
Component commits:
0d61b14 addImplementationSuccessElaboration admits declarations with no symbol

Co-authored-by: Wesley Wigham <t-weswig@microsoft.com>
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@weswigham weswigham

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic React HOC: TypeError: Cannot read property 'declarations' of undefined
3 participants
@weswigham @typescript-bot @andrewbranch