🤖 Pick PR #41479 (Add missed resolveSymbol in comm...) into release-4.1 #41691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes resolution of export aliases in the postfix-property-access case
of commonjs require:
```js
const { x } = require('./foo').nested
x
```
This program would previously fail if `x` was an export alias.
Fixes microsoft#41422
typescript-bot
added
Author: Team
For Uncommitted Bug
nitish-awasthi
approved these changes
Nov 26, 2020
sandersn
approved these changes
Dec 1, 2020
|
@andrewbranch is this ready to merge? |
|
đź‘Ť (attn: @DanielRosenwasser) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beep boop I’m @typescript-bot
This cherry-pick was not triggered by a request on #41479 because I’m snoozin’ on the job.
Please review the diff and merge if no changes are unexpected.
You cannot view the cherry-pick log.
cc @andrewbranch