Fix call hierarchy item serialization #40348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
andrewbranch
commented
Sep 1, 2020
| @@ -2408,6 +2408,7 @@ namespace ts.server { | |||
| kind: item.kind, | |||
| kindModifiers: item.kindModifiers, | |||
| file: item.file, | |||
| containerName: item.containerName, | |||
There was a problem hiding this comment.
This line is the implementation fix. Other changes are fixes to test infrastructure that was never used before now.
|
@typescript-bot cherry-pick this to release-4.0 |
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Sep 1, 2020
Component commits: 3b33279 Fix call hierarchy item serialization and server tests
|
Hey @andrewbranch, I've opened #40349 for you. |
mjbvz
approved these changes
Sep 1, 2020
|
I’m guessing we want to get this in our VS Code servicing release. @DanielRosenwasser I’ve cherry picked this PR but should we wait to merge it until after another patch release? |
|
Yes that would be great. We're in our endgame this week for VS Code so I don't think this will make it into VS Code 1.49. We'd normally pick up the next TS servicing release by the end of September but can pick one up anytime for testing in insiders |
weswigham
pushed a commit
that referenced
this pull request
Sep 2, 2020
andrewbranch
added a commit
that referenced
this pull request
Sep 8, 2020
Component commits: 3b33279 Fix call hierarchy item serialization and server tests Co-authored-by: Andrew Branch <andrew@wheream.io>
sandersn
pushed a commit
that referenced
this pull request
Sep 9, 2020
* Add see tag parser * add baseline * fix symbol resolve * add more case * fix unittests * improve tests and parser * accept baseline * Adopt package-lock.json and npm ci * Add a workflow to update package-lock.json daily * Git ignore package-lock.json and forcibly update in workflow * Update bot email address * Delete extra npm update * Update package-lock.json * Add compactDisplay and signDisplay to NumberFormatOptions (#40039) * Fix typo in (Readonly)Set.keys comment (fixes #40164) (#40176) * fix(26325): use a unique name for reserved words in 'constructor like' function name (#39684) * fix(25770): add diagnostic message for the possible mapped type used as an index (#39973) * fix(31046): add new diagnostic message for incompatible constructor signature (#40073) * Update package-lock.json * Update package-lock.json * Add rename support * Accpet baseline * wip * fix anders * Revert "fix anders" This reverts commit b3178d4. * Fix call hierarchy item serialization and server tests (#40348) * Avoid error * accept baseline * Add more tests * Add signature name resolve Co-authored-by: Andrew Casey <andrew.casey@microsoft.com> Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com> Co-authored-by: Neil Kistner <neil.kistner@gmail.com> Co-authored-by: cherryblossom000 <31467609+cherryblossom000@users.noreply.github.com> Co-authored-by: Alexander T <alexander.tarasyuk@outlook.com> Co-authored-by: Erich Gamma <egamma@microsoft.com> Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37061