Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add '(approximate)' to the beginning of quick info requests in PartialSemantic mode" #40072

Merged
merged 1 commit into from Aug 17, 2020

Conversation

DanielRosenwasser
Copy link
Member

Reverts #40061 since there were some concerns over whether the editor should do this instead.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 16, 2020
@DanielRosenwasser
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 16, 2020

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at 1582b76. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #40076 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 16, 2020
Component commits:
1582b76 Revert "Add '(approximate)' to the beginning of quick info requests in PartialSemantic mode (microsoft#40061)"
This reverts commit 2426eb4.
DanielRosenwasser added a commit that referenced this pull request Aug 17, 2020
Component commits:
1582b76 Revert "Add '(approximate)' to the beginning of quick info requests in PartialSemantic mode (#40061)"
This reverts commit 2426eb4.

Co-authored-by: Daniel Rosenwasser <drosen@microsoft.com>
@DanielRosenwasser DanielRosenwasser merged commit 97a0729 into master Aug 17, 2020
@DanielRosenwasser DanielRosenwasser deleted the revert-40061-approximateQuickInfo branch August 17, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants