Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to including only open files in partial semantic server mode #40026

Merged
merged 1 commit into from Aug 13, 2020

Conversation

sheetalkamat
Copy link
Member

No description provided.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 13, 2020
@sheetalkamat sheetalkamat requested review from andrewbranch, amcasey and DanielRosenwasser and removed request for andrewbranch August 13, 2020 00:23
@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 13, 2020

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-4.0 on this PR at 8f442ba. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #40028 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 13, 2020
Component commits:
8f442ba Revert to including only open files in partial semantic server mode
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the code in detail, but I'm totally on board with the concept.

@DanielRosenwasser
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 13, 2020

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 8f442ba. You can monitor the build here.

Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naively, looks good. I'll try this out locally tonight and merge the 4.0 PR if appropriate.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/82128/artifacts?artifactName=tgz&fileId=99F1C6B75D4971FA0FC0D61D468B548EBFA9CF777E23EA64619C9D20DAF7791202&fileName=/typescript-4.1.0-insiders.20200813.tgz"
    }
}

and then running npm install.

@DanielRosenwasser
Copy link
Member

Looks good to me locally after some finagling.

DanielRosenwasser pushed a commit that referenced this pull request Aug 13, 2020
Component commits:
8f442ba Revert to including only open files in partial semantic server mode

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
@DanielRosenwasser DanielRosenwasser merged commit 03d946d into master Aug 13, 2020
@sheetalkamat sheetalkamat deleted the openFileOnly branch August 13, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants