New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load ETW module from a specified path #39599
Conversation
@typescript-bot cherry-pick this to release-3.9 |
Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into |
Hey @RyanCavanaugh, I've opened #39601 for you. |
Component commits: c8d5b98 Load ETW module from a specified path
@typescript-bot cherry-pick this to release-3.9 |
Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into |
Hey @RyanCavanaugh, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.9 manually. |
Component commits: c8d5b98 Load ETW module from a specified path
Component commits: c8d5b98 Load ETW module from a specified path Co-authored-by: Michael Crane <micran@microsoft.com>
Do not rely on the default module resolution algorithm to load the optional typescript-etw module. Load it from the node_modules path that is local to the running server. This is where it is shipped with the Windows TypeScript SDK.
Also allow the path to be specified with the TS_ETW_MODULE_PATH environment variable. This will enable new use cases, e.g. VS Code.