Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip default when initially iterating exports in __importStar, same as __exportStar #38808

Merged
merged 2 commits into from Jun 1, 2020
Merged

Skip default when initially iterating exports in __importStar, same as __exportStar #38808

merged 2 commits into from Jun 1, 2020

Conversation

weswigham
Copy link
Member

Fixes #38540

@weswigham weswigham mentioned this pull request May 27, 2020
Merged
@weswigham
Copy link
Member Author

@RyanCavanaugh will we want to backport this to the 3.9 servicing release?

@DanielRosenwasser
Copy link
Member

@typescript-bot pack this
@typescript-bot cherry-pick this to release-3.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 27, 2020 •
edited

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 1da7d7a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 27, 2020 •
edited

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-3.9 on this PR at 1da7d7a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #38811 for you.

@typescript-bot typescript-bot mentioned this pull request May 27, 2020
Merged
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 27, 2020
@weswigham
Cherry-pick PR microsoft#38808 into release-3.9
c34b39b 
Component commits:
2906ce4 Skip default when iterating exports in __importStar, same as __exportStar

1da7d7a Accept baselines
@DanielRosenwasser DanielRosenwasser mentioned this pull request May 27, 2020
Merged
@typescript-bot
Copy link
Collaborator

typescript-bot commented May 27, 2020 •
edited

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/75073/artifacts?artifactName=tgz&fileId=6C00FE3605AD1F9E537C858359588BAD1248C4EF90BBFF217AA57949BBD75F0F02&fileName=/typescript-4.0.0-insiders.20200527.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

@DanielRosenwasser DanielRosenwasser mentioned this pull request May 27, 2020
Closed
DanielRosenwasser added a commit that referenced this pull request May 28, 2020
@DanielRosenwasser
Merge pull request #38811 from typescript-bot/pick/38808/release-3.9
28ea935 
🤖 Pick PR #38808 (Skip default when initially iterati...) into release-3.9
@weswigham weswigham merged commit b36b803 into microsoft:master Jun 1, 2020
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request Jun 2, 2020
@cangSDARM
Merge remote-tracking branch 'upstream/master'
59a3320 
* upstream/master: (78 commits)
  LEGO: check in for master to temporary branch.
  Skip default when initially iterating exports in __importStar, same as __exportStar (microsoft#38808)
  fix line endings
  Improve error range for ts2657 (jsx expr must have parent element), add code fix for it (microsoft#37917)
  fix(32341): add prefix name for module exports properties (microsoft#38541)
  fix(19385): add space after brace in the multiline string template (microsoft#38742)
  fix(38815): dive in arrow functions to check only this usage instead of checking all statements (microsoft#38865)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Convert HTML tags in doc-comments into markdown
  fix linting error
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  fix(38722): change error message for use-before-declaration on const enum (microsoft#38728)
  ...
This was referenced Jul 7, 2020
Closed
Closed
@rbuckton rbuckton mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@weswigham weswigham

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error with *esModuleInterop* when CJS module has an export named "default"
4 participants
@weswigham @DanielRosenwasser @typescript-bot @sheetalkamat