Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Pick PR #38579 (Ensure formatter can always get a n...) into release-3.9 #38666

Merged
merged 1 commit into from
May 19, 2020
Merged

🤖 Pick PR #38579 (Ensure formatter can always get a n...) into release-3.9 #38666

merged 1 commit into from
May 19, 2020

Conversation

typescript-bot
Copy link
Collaborator

This cherry-pick was triggered by a request on #38579
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.

cc @andrewbranch

@andrewbranch
Cherry-pick PR microsoft#38579 into release-3.9
dbe9092 
Component commits:
0a696c9 Ensure formatter can always get a newline character

ab09d67 Make FormatContext.host optional since it’s not necessary if format options are all applied

90923e2 Make FormattingHost required again
@typescript-bot typescript-bot mentioned this pull request May 19, 2020
Merged
@andrewbranch andrewbranch self-assigned this May 19, 2020
@andrewbranch
Copy link
Member

@DanielRosenwasser should I go ahead and merge this?

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 19, 2020 •
edited

You get the honor of merging. ⭐

@andrewbranch andrewbranch merged commit 5b29b14 into microsoft:release-3.9 May 19, 2020
@mathieumg mathieumg mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@andrewbranch andrewbranch

Labels
None yet
Projects
None yet
Milestone
TypeScript 3.9.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@typescript-bot @andrewbranch @DanielRosenwasser