Fix regression organize imports duplicates comments #38599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/services/textChanges.ts
Outdated
| @@ -286,6 +286,12 @@ namespace ts.textChanges { | |||
| this.deletedNodes.push({ sourceFile, node }); | |||
| } | |||
|
|
|||
| public deleteNode(sourceFile: SourceFile, node: Node, options: ConfigurableStartEnd = { leadingTriviaOption: LeadingTriviaOption.IncludeAll }): void { | |||
| const startPosition = getAdjustedStartPosition(sourceFile, node, options); | |||
| const endPosition = getAdjustedEndPosition(sourceFile, node, options); | |||
There was a problem hiding this comment.
use getAdjustedRange instead
sheetalkamat
approved these changes
May 15, 2020
andrewbranch
approved these changes
May 15, 2020
cangSDARM
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
May 18, 2020
* upstream/master: Use control flow analysis to check 'super(...)' call before 'this' access (microsoft#38612) LEGO: check in for master to temporary branch. Make `processTaggedTemplateExpression` visit a returned node goToDefinition: find only the value if it's the RHS of an assignment Fix regression organize imports duplicates comments (microsoft#38599) Fix crash in JS declaration emit (microsoft#38508)
|
@typescript-bot cherry-pick this to release-3.9 |
|
@typescript-bot cherry-pick this to release-3.9 I wonder if you need to be added to a list/role somewhere |
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 19, 2020
|
Hey @andrewbranch, I've opened #38668 for you. |
DanielRosenwasser
added a commit
that referenced
this pull request
May 19, 2020
🤖 Pick PR #38599 (Fix regression organize imports dup...) into release-3.9
typescript-bot
added
the
For Milestone Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38507
#37467 started preserving comments when deleting unused declarations. When organize imports creates a sorted list of imports, it deletes the old imports in the same way. This caused us to start duplicating comments when organizing imports.