New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compileOnSaveEmit when using source of project reference redirect with --out #35335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
rbuckton,
sandersn,
amcasey,
andrewbranch,
elibarzilay,
orta,
RyanCavanaugh and
weswigham
November 25, 2019 21:33
sheetalkamat
force-pushed
the
compileOnSaveOutFile
branch
from
November 25, 2019 22:08
466a74d
to
d7e4a4e
Compare
… with --out Fixes #35226
sheetalkamat
force-pushed
the
compileOnSaveOutFile
branch
from
November 26, 2019 19:11
d7e4a4e
to
c44de23
Compare
@typescript-bot cherry-pick this to release-3.7 |
Hey @sheetalkamat, I've opened #35367 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Nov 26, 2019
Component commits: c44de23 Fix compileOnSaveEmit when using source of project reference redirect with --out Fixes microsoft#35226
RyanCavanaugh
approved these changes
Nov 27, 2019
@typescript-bot cherry-pick this to release-3.7 |
Hey @sheetalkamat, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Nov 27, 2019
Component commits: c44de23 Fix compileOnSaveEmit when using source of project reference redirect with --out Fixes microsoft#35226 522efb4 Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Fixes #35226