useDefineForClassFields skips emit of ambient properties #35058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously:
```ts
class C {
declare p
}
```
would incorrectly emit
```js
class C {
constructor() {
Object.defineProperty(this, "p", {
enumerable: true,
configurable: true,
writable: true,
value: void 0
});
}
}
```
when useDefineForClassFields was turned on (for targets <ESNext).
Note the ESNext emit was also broken. Maybe that needs a snapshot test too? |
This moves the check earlier in the pipeline.
|
@robpalme Thanks, that resulted in a better place to put the new check. I also ported the new test |
|
@typescript-bot cherry-pick this to release-3.7 |
|
🔔 reviewers can we get some eyes on this so we can get 3.7.3 out sooner? |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Nov 20, 2019
Component commits: 8ae5a8c useDefineForClassFields skips emit of ambient properties Previously: ```ts class C { declare p } ``` would incorrectly emit ```js class C { constructor() { Object.defineProperty(this, "p", { enumerable: true, configurable: true, writable: true, value: void 0 }); } } ``` when useDefineForClassFields was turned on (for targets <ESNext). 0ec9c04 Fix bug for ESNext as well This moves the check earlier in the pipeline. e1aa034 update baselines
|
Hey @DanielRosenwasser, I've opened #35241 for you. |
rbuckton
approved these changes
Nov 22, 2019
DanielRosenwasser
deleted the
useDefineForClassFields-skip-emit-ambient-properties
branch
DanielRosenwasser
pushed a commit
that referenced
this pull request
Nov 22, 2019
Component commits: 8ae5a8c useDefineForClassFields skips emit of ambient properties Previously: ```ts class C { declare p } ``` would incorrectly emit ```js class C { constructor() { Object.defineProperty(this, "p", { enumerable: true, configurable: true, writable: true, value: void 0 }); } } ``` when useDefineForClassFields was turned on (for targets <ESNext). 0ec9c04 Fix bug for ESNext as well This moves the check earlier in the pipeline. e1aa034 update baselines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
would incorrectly emit
when useDefineForClassFields was turned on (for targets <ESNext).
Fixes #34972