Bind typedef/enum on all assignment declaration kinds #33240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
sandersn
changed the title
sheetalkamat
approved these changes
Sep 4, 2019
weswigham
approved these changes
Sep 4, 2019
|
@typescript-bot cherry-pick this |
|
@typescript-bot cherry-pick this to release-3.6 |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Sep 4, 2019
Component commits: 339e132 Bind typedef/enum on all assignment decl kinds This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
sandersn
pushed a commit
that referenced
this pull request
Sep 4, 2019
Component commits: 339e132 Bind typedef/enum on all assignment decl kinds This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
|
Wow, amazing response time @sandersn! Thanks for the super quick fix! :) |
|
Well, we are actively fixing 3.6 crashes since it's a new release. It should be out in less than a week as |
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Sep 5, 2019
…)" This reverts commit b542bdf.
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
Fixes #33230