Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass the TSServer CRLF bug #767

Merged
merged 1 commit into from Feb 9, 2021
Merged

Bypass the TSServer CRLF bug #767

merged 1 commit into from Feb 9, 2021

Conversation

borodean
Copy link
Contributor

Addresses #765.

The plugin broke in the master branch after adding commit 64991b1. After adding it, when NodeCommClient receives a message with an empty header, it tries to read an error from stderr.

TSServer doesn't handle line breaks correctly on Windows (microsoft/TypeScript#3403). Because of this the messages are parsed incorrectly, and the plugin gets into the very piece of code where it now tries to read an error. Before it used to just quit the function at that point and the parsing problem went unnoticed, but now the plugin is stuck trying to read stderr.

I found the information about the method of solving the problem here: ycm-core/ycmd#503.

Hopefully, this will unblock the new release.

@microsoft-cla-retired
Copy link

microsoft-cla-retired bot commented Jan 23, 2021

CLA assistant check
All CLA requirements met.

@orta
Copy link
Contributor

orta commented Jan 31, 2021

Oh! OK, great - I'll give this a run next week, thanks

@orta orta mentioned this pull request Jan 31, 2021
@orta
Copy link
Contributor

orta commented Feb 9, 2021

I've given this PR a run locallay and it worked for me on Windows + ST3 - thanks @borodean

@orta orta merged commit 27c0c0c into microsoft:master Feb 9, 2021
@borodean borodean deleted the ts-server-cr-lf-fix branch February 9, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants