Skip to content

Update some events to Warning, add more data #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Conversation

benmwatson
Copy link
Member

I was recently debugging a metrics issue stemming from RecyclableMemoryStream and at one point I wished I had a bit more data in some of these events. There are two changes:

Change Justification
Change Block/Buffer creation events to Warning from Verbose After the pool is "warmed" up, these should be rare occurrences, and indicate that the configured slack space is insufficient. Downside is that when the pool is warming up, there will be more. However, if you're debugging at a later point, it's much easier to see these events without the sea of verbose events.
Add pool info to Discard event On the flip side, if a buffer/block is discarded, the pool is larger than anticipated. It would be useful to see exactly the state.

@benmwatson benmwatson added this to the 2.0 milestone Feb 3, 2023
benmwatson and others added 3 commits February 6, 2023 10:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@benmwatson benmwatson merged commit 362550d into master Feb 6, 2023
@benmwatson benmwatson deleted the tweakevents branch February 6, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants