Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introspection produces unexpected results after upgrading to 1.2.0-rc.1 #1149

Open
oliversalzburg opened this issue Dec 22, 2021 · 1 comment
Labels
Need More Info 🤷‍♂️ Further information is requested Question ❔ Not future request, proposal or bug issue

Comments

@oliversalzburg
Copy link
Contributor

Describe the Bug
After upgrading to 1.2.0-rc.1, when GraphQL Playground runs an introspection query, it will complain about input types that have no fields.

To Reproduce
Create an input type where all fields are deprecated.

Expected Behavior
The deprecated fields are returned, the introspection succeeds and GraphQL Playground is able to operate normally.

Environment (please complete the following information):

  • OS: Windows WSL
  • Node 16.x
  • Package version 1.2.0-rc.1
  • TypeScript version 4.5.4

Additional Context
From what I understand, this is likely caused by the graphql-js upgrade. I found graphql/graphql-js#2834 which hints at this issue. I found no way how to affect this behavior from type-graphql itself.

@MichalLytek
Copy link
Owner

this is likely caused by the graphql-js upgrade

Please try to reproduce it with v1.1.1 and graphql-js@15.8.0.

If so, then report it in the graphql-js repo as it's now caused by type-graphql itself.
If you think it is, then propose a solution to fix it 😉

@MichalLytek MichalLytek added Need More Info 🤷‍♂️ Further information is requested Question ❔ Not future request, proposal or bug issue labels Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need More Info 🤷‍♂️ Further information is requested Question ❔ Not future request, proposal or bug issue
Projects
None yet
Development

No branches or pull requests

2 participants