Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-fetch #59

Closed
MichaelPachec0 opened this issue Aug 5, 2022 · 0 comments · Fixed by #60
Closed

Update node-fetch #59

MichaelPachec0 opened this issue Aug 5, 2022 · 0 comments · Fixed by #60

Comments

@MichaelPachec0
Copy link
Owner

MichaelPachec0 commented Aug 5, 2022

According to node-fetch/node-fetch#1611 earlier versions of node fetch are vulnerable to DOS when the the user can manipulate the url referrer. While the user of this app wont be able to do this, it does not make sense to keep a vulnerable version when none of the changes affect usability.

Tasks to be done:

  • Create a branch where node-fetch is update to a non-vulnerable version
  • Test it and assess if there are any functionality issues.
  • If not then send a pr as is, else comment here and create a new issue about such issues with node-fetch which can then be referenced when a pr gets sent with fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant