From db202257e0d639d754ac17c53c1deb18456bb220 Mon Sep 17 00:00:00 2001 From: Frederik Bolding Date: Mon, 24 Oct 2022 14:21:59 +0200 Subject: [PATCH 1/5] Bump GitHub actions --- .github/workflows/build-lint-test.yml | 12 ++++++------ .github/workflows/create-release-pr.yml | 6 +++--- .github/workflows/publish-release.yml | 8 ++++---- .github/workflows/require-additional-reviewer.yml | 2 +- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build-lint-test.yml b/.github/workflows/build-lint-test.yml index 872cd5d0db..c9ffc07d86 100644 --- a/.github/workflows/build-lint-test.yml +++ b/.github/workflows/build-lint-test.yml @@ -13,16 +13,16 @@ jobs: matrix: node-version: [16.x, 18.x] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v2 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - name: Get Yarn version run: echo "::set-output name=YARN_VERSION::$(yarn --version)" id: yarn-version - name: Cache yarn dependencies - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: .yarn/cache key: yarn-cache-${{ runner.os }}-${{ steps.yarn-version.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }} @@ -60,15 +60,15 @@ jobs: matrix: os: [macOS-latest, windows-latest] steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/checkout@v3 + - uses: actions/setup-node@v3 with: node-version: 18.x - name: Get Yarn version run: echo "::set-output name=YARN_VERSION::$(yarn --version)" id: yarn-version - name: Cache yarn dependencies - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: .yarn/cache key: yarn-cache-${{ runner.os }}-${{ steps.yarn-version.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }} diff --git a/.github/workflows/create-release-pr.yml b/.github/workflows/create-release-pr.yml index e843833d04..7f27e3489e 100644 --- a/.github/workflows/create-release-pr.yml +++ b/.github/workflows/create-release-pr.yml @@ -21,7 +21,7 @@ jobs: contents: write pull-requests: write steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: # This is to guarantee that the most recent tag is fetched. # This can be configured to a more reasonable value by consumers. @@ -32,7 +32,7 @@ jobs: - name: Get Node.js version id: nvm run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc) - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: ${{ steps.nvm.outputs.NODE_VERSION }} - uses: MetaMask/action-create-release-pr@v1 @@ -43,7 +43,7 @@ jobs: release-version: ${{ github.event.inputs.release-version }} artifacts-path: gh-action__release-authors # Upload the release author artifact for use in subsequent workflows - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 with: name: release-authors path: gh-action__release-authors diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index d1b9938d4a..0f11afc8b3 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -22,13 +22,13 @@ jobs: runs-on: ubuntu-latest needs: is-release steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: ref: ${{ github.sha }} - name: Get Node.js version id: nvm run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc) - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: ${{ steps.nvm.outputs.NODE_VERSION }} - uses: MetaMask/action-publish-release@v2.0.0 @@ -50,7 +50,7 @@ jobs: runs-on: ubuntu-latest needs: publish-release steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: ref: ${{ github.sha }} - uses: actions/cache@v3 @@ -69,7 +69,7 @@ jobs: runs-on: ubuntu-latest needs: npm-publish-dry-run steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: ref: ${{ github.sha }} - uses: actions/cache@v3 diff --git a/.github/workflows/require-additional-reviewer.yml b/.github/workflows/require-additional-reviewer.yml index 1ea1c06263..ea46ee9beb 100644 --- a/.github/workflows/require-additional-reviewer.yml +++ b/.github/workflows/require-additional-reviewer.yml @@ -13,7 +13,7 @@ jobs: statuses: write runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: # If the base branch has been merged into the release branch, we # need to find the earliest common ancestor commit of the base and From e05c817725906a858337e9a17be27488ba98b599 Mon Sep 17 00:00:00 2001 From: Frederik Bolding Date: Mon, 24 Oct 2022 14:28:00 +0200 Subject: [PATCH 2/5] Replace set-output --- .github/workflows/build-lint-test.yml | 4 ++-- .github/workflows/create-release-pr.yml | 2 +- .github/workflows/publish-release.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-lint-test.yml b/.github/workflows/build-lint-test.yml index c9ffc07d86..e7dd25f8c3 100644 --- a/.github/workflows/build-lint-test.yml +++ b/.github/workflows/build-lint-test.yml @@ -19,7 +19,7 @@ jobs: with: node-version: ${{ matrix.node-version }} - name: Get Yarn version - run: echo "::set-output name=YARN_VERSION::$(yarn --version)" + run: echo "{YARN_VERSION}={$(yarn --version)}" >> $GITHUB_OUTPUT id: yarn-version - name: Cache yarn dependencies uses: actions/cache@v3 @@ -65,7 +65,7 @@ jobs: with: node-version: 18.x - name: Get Yarn version - run: echo "::set-output name=YARN_VERSION::$(yarn --version)" + run: echo "{YARN_VERSION}={$(yarn --version)}" >> $GITHUB_OUTPUT id: yarn-version - name: Cache yarn dependencies uses: actions/cache@v3 diff --git a/.github/workflows/create-release-pr.yml b/.github/workflows/create-release-pr.yml index 7f27e3489e..852c5e2ac9 100644 --- a/.github/workflows/create-release-pr.yml +++ b/.github/workflows/create-release-pr.yml @@ -31,7 +31,7 @@ jobs: ref: ${{ github.event.inputs.base-branch }} - name: Get Node.js version id: nvm - run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc) + run: echo "{NODE_VERSION}={$(cat .nvmrc)}" >> $GITHUB_OUTPUT - uses: actions/setup-node@v3 with: node-version: ${{ steps.nvm.outputs.NODE_VERSION }} diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 0f11afc8b3..bf71df43ed 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -27,7 +27,7 @@ jobs: ref: ${{ github.sha }} - name: Get Node.js version id: nvm - run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc) + run: echo "{NODE_VERSION}={$(cat .nvmrc)}" >> $GITHUB_OUTPUT - uses: actions/setup-node@v3 with: node-version: ${{ steps.nvm.outputs.NODE_VERSION }} From 40428d21abac2e9554162592c89248cfd2ea31da Mon Sep 17 00:00:00 2001 From: Frederik Bolding Date: Mon, 24 Oct 2022 14:34:14 +0200 Subject: [PATCH 3/5] formatting --- .github/workflows/build-lint-test.yml | 4 ++-- .github/workflows/create-release-pr.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-lint-test.yml b/.github/workflows/build-lint-test.yml index e7dd25f8c3..00df95cee6 100644 --- a/.github/workflows/build-lint-test.yml +++ b/.github/workflows/build-lint-test.yml @@ -19,7 +19,7 @@ jobs: with: node-version: ${{ matrix.node-version }} - name: Get Yarn version - run: echo "{YARN_VERSION}={$(yarn --version)}" >> $GITHUB_OUTPUT + run: echo "YARN_VERSION=$(yarn --version)" >> $GITHUB_OUTPUT id: yarn-version - name: Cache yarn dependencies uses: actions/cache@v3 @@ -65,7 +65,7 @@ jobs: with: node-version: 18.x - name: Get Yarn version - run: echo "{YARN_VERSION}={$(yarn --version)}" >> $GITHUB_OUTPUT + run: echo "YARN_VERSION=$(yarn --version)" >> $GITHUB_OUTPUT id: yarn-version - name: Cache yarn dependencies uses: actions/cache@v3 diff --git a/.github/workflows/create-release-pr.yml b/.github/workflows/create-release-pr.yml index 852c5e2ac9..2d8a2cc8c8 100644 --- a/.github/workflows/create-release-pr.yml +++ b/.github/workflows/create-release-pr.yml @@ -31,7 +31,7 @@ jobs: ref: ${{ github.event.inputs.base-branch }} - name: Get Node.js version id: nvm - run: echo "{NODE_VERSION}={$(cat .nvmrc)}" >> $GITHUB_OUTPUT + run: echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_OUTPUT - uses: actions/setup-node@v3 with: node-version: ${{ steps.nvm.outputs.NODE_VERSION }} From 052d213fb5aa120a7d14721bbdfbbaac5e7bacc6 Mon Sep 17 00:00:00 2001 From: Frederik Bolding Date: Mon, 24 Oct 2022 14:34:38 +0200 Subject: [PATCH 4/5] formatting --- .github/workflows/publish-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index bf71df43ed..b64bddcebb 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -27,7 +27,7 @@ jobs: ref: ${{ github.sha }} - name: Get Node.js version id: nvm - run: echo "{NODE_VERSION}={$(cat .nvmrc)}" >> $GITHUB_OUTPUT + run: echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_OUTPUT - uses: actions/setup-node@v3 with: node-version: ${{ steps.nvm.outputs.NODE_VERSION }} From 0d20afa933d09002cec4b1527eb42acd822a64ee Mon Sep 17 00:00:00 2001 From: Frederik Bolding Date: Mon, 24 Oct 2022 14:59:34 +0200 Subject: [PATCH 5/5] Use bash --- .github/workflows/build-lint-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-lint-test.yml b/.github/workflows/build-lint-test.yml index 00df95cee6..1fd4bb1099 100644 --- a/.github/workflows/build-lint-test.yml +++ b/.github/workflows/build-lint-test.yml @@ -66,6 +66,7 @@ jobs: node-version: 18.x - name: Get Yarn version run: echo "YARN_VERSION=$(yarn --version)" >> $GITHUB_OUTPUT + shell: bash id: yarn-version - name: Cache yarn dependencies uses: actions/cache@v3