Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop prefixing private functions with _ #887

Closed
FrederikBolding opened this issue Oct 31, 2022 · 2 comments · Fixed by #930
Closed

Stop prefixing private functions with _ #887

FrederikBolding opened this issue Oct 31, 2022 · 2 comments · Fixed by #930
Assignees
@FrederikBolding
Labels
type-enhancement New feature or request

Comments

@FrederikBolding
Copy link
Member

We should stop the pattern of prefixing private functions with _.

We could also consider using # for proper private functions.
@FrederikBolding FrederikBolding added the type-enhancement New feature or request label Oct 31, 2022
@FrederikBolding FrederikBolding mentioned this issue Oct 31, 2022
Merged
@Mrtenz
Copy link
Member

Mrtenz commented Oct 31, 2022

We could also consider using # for proper private functions.

If we're going to be replacing it, I'd say that all functions should be actually private.

@FrederikBolding FrederikBolding self-assigned this Oct 31, 2022
@FrederikBolding
Copy link
Member Author

We could also consider using # for proper private functions.

If we're going to be replacing it, I'd say that all functions should be actually private.

We can, but this will require rewriting a bunch of tests and will generally make testing harder.

See #930

@FrederikBolding FrederikBolding mentioned this issue Nov 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikBolding FrederikBolding

Labels
type-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop prefixing private functions and properties with _ MetaMask/snaps
2 participants
@FrederikBolding @Mrtenz