Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning when using Math.random #950

Merged
merged 2 commits into from Nov 11, 2022
Merged

Show warning when using Math.random #950

merged 2 commits into from Nov 11, 2022

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 11, 2022 •
edited

This adds a warnings property to the result of post processing, and adds a warning when Math.random is detected in the bundle.

@Mrtenz Mrtenz marked this pull request as ready for review November 11, 2022 10:51
@Mrtenz Mrtenz requested a review from a team as a code owner November 11, 2022 10:51
FrederikBolding
FrederikBolding approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@FrederikBolding FrederikBolding left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mrtenz Mrtenz merged commit b074caf into main Nov 11, 2022
@Mrtenz Mrtenz deleted the mrtenz/warn-on-math-random branch November 11, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mrtenz @FrederikBolding