BREAKING: Remove wallet_enable and wallet_installSnaps in favor of wallet_requestSnaps
#909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
changed the title
wallet_enable in favor of wallet_installSnapswallet_enable in favor of wallet_requestSnaps
FrederikBolding
changed the title
wallet_enable in favor of wallet_requestSnapswallet_enable and wallet_installSnaps in favor of wallet_requestSnaps
Mrtenz
requested changes
Nov 9, 2022
FrederikBolding
force-pushed
the
fb/replace-wallet-enable
branch
from
e6e5663
to
a173d93
Compare
Mrtenz
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
wallet_enableandwallet_installSnapsin favor ofwallet_requestSnapswhich is an updated version ofwallet_installSnapsthat requests permission for the requesting DApp to talk to the installed snap mirroring partly thewallet_enablelogic.Fixes #894