Improve keyring endowment error messaging #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritave
previously approved these changes
Oct 28, 2022
| throw ethErrors.rpc.invalidParams({ | ||
| message: 'Expected a valid namespaces object.', | ||
| message: `Invalid namespaces object: ${error.message}.`, |
There was a problem hiding this comment.
Superstruct validates errors lazily, if you want, we could show all of them. error.failures() returns a list of all of them all
ritave
reviewed
Oct 28, 2022
ritave
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a Snap would specify an invalid keyring namespace object, we would throw an error like:
This does not explain exactly what the issue is. This changes it to throw more descriptive errors, i.e., the errors thrown by Superstruct, but wrapped in a JSON-RPC error. For example: