Remove JSON schemas in favour of structs #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/remove-json-schemas
branch
from
0d0c74c
to
132fbdb
Compare
ritave
requested changes
Oct 26, 2022
There was a problem hiding this comment.
I'm generally all for this change.
Could we talk through implementing / not implementing https://github.com/MetaMask/SIPs/blob/main/SIPS/sip-4.md before merging this though? No need to duplicate efforts
The work for this PR is already done. If we decide on merging the two, we'd need to redo the work regardless, so I don't think it makes any difference. |
ritave
previously approved these changes
Oct 26, 2022
FrederikBolding
approved these changes
Oct 26, 2022
Mrtenz
force-pushed
the
mrtenz/remove-json-schemas
branch
from
5910849
to
c7e974d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
package.jsonandsnap.manifest.jsonJSON schemas in favour ofsuperstruct.To do