Stop including source code in state #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
changed the title
Mrtenz
requested changes
Oct 26, 2022
FrederikBolding
force-pushed
the
fb/stop-including-source-in-state
branch
from
88d28b3
to
5e5944e
Compare
Mrtenz
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops storing the snap source code in the state of the controller, since this causes the source code to be piped to the extension UI every 200ms. With this PR, the source code is instead kept alongside other runtime data, being loaded when the controller spins up and persisted when it spins down.
This will also make it easier for us to store the sourceCode in another format in the near future.
Fixes #859