Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Webpack plugin issue with existing files #858

Merged
merged 5 commits into from Oct 26, 2022

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 25, 2022

Fixes an issue where already built files would be ignored by the Webpack plugin. This was fixed by using another hook to capture the emit (afterEmit), since the previous hook would not be called if the output file already existed.

Fixes #811

@FrederikBolding FrederikBolding marked this pull request as ready for review October 25, 2022 10:57
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 25, 2022 10:57
packages/plugin-webpack/src/plugin.ts Outdated Show resolved Hide resolved
packages/plugin-webpack/src/plugin.ts Outdated Show resolved Hide resolved
@FrederikBolding FrederikBolding merged commit 99f1fcd into main Oct 26, 2022
@FrederikBolding FrederikBolding deleted the fb/fix-webpack-plugin-on-existing-files branch October 26, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack plugin not updating version in manifest
2 participants