Fix missing properties on WebSocket MessageEvent #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
commented
Oct 12, 2022
| composedPath: () => [this], | ||
| }, | ||
| ]); | ||
| // TODO: Should we migrate this to use a wrapper class? |
There was a problem hiding this comment.
We could replace this entire thing with a wrapper class same as we do for responses 🤔
Mrtenz
reviewed
Oct 13, 2022
Mrtenz
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing properties on WebSocket MessageEvent. We were spreading the object instead of navigating the prototype chain to look for the properties, as such, not all properties were correctly copied to the event.
Fixes #836