BREAKING: SnapController.installSnaps Refactor & Rollback Functionality Added
#1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmalik88
changed the title
SnapController.installSnaps Refactor & Rollback Functionality Added
FrederikBolding
changed the title
SnapController.installSnaps Refactor & Rollback Functionality AddedSnapController.installSnaps Refactor & Rollback Functionality Added
FrederikBolding
force-pushed
the
hm/update-rollback-mechanism
branch
from
4106808
to
ad502f7
Compare
Mrtenz
previously requested changes
Dec 6, 2022
…aps-monorepo into hm/update-rollback-mechanism
Mrtenz
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to @FrederikBolding 's work for #893. His work addresses changing to a pattern of throwing errors instead of returning and also rolling back installs to help ensure atomicity for multi-snap calls to
installSnapsin theSnapsController. My work added rollback functionality for updates.Fixes #893
Fixes #612