Simplify controller tests #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/simplify-controller-tests
branch
from
9ae617f
to
37b2097
Compare
Codecov Report
@@ Coverage Diff @@
## main #983 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 96 96
Lines 9578 9578
Branches 903 903
=======================================
Hits 8902 8902
Misses 676 676 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Mrtenz
force-pushed
the
mrtenz/simplify-controller-tests
branch
from
3f3cc6e
to
e839959
Compare
|
|
||
| expect( | ||
| // Race the promises to check that handlerPromise does not time out | ||
| await Promise.race([handlerPromise, timeoutPromise]), | ||
| ).toBe(true); | ||
| ).toBe('test1'); |
There was a problem hiding this comment.
Where does test1 come from here?
There was a problem hiding this comment.
From DEFAULT_SNAP_BUNDLE. It returns method + id.
| @@ -1109,14 +1058,16 @@ describe('SnapController', () => { | |||
| id: 1, | |||
| }, | |||
| }), | |||
| ).toBe(21896430); | |||
| ).toBe(21896426); | |||
There was a problem hiding this comment.
How is this returning a number? 🤔
There was a problem hiding this comment.
I don't know. It was doing it before too though.
This reverts commit 3252375.
Mrtenz
force-pushed
the
mrtenz/simplify-controller-tests
branch
from
a1b2681
to
73ce156
Compare
FrederikBolding
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than mocking messenger calls, I've changed the tests to use
registerActionHandler. This has a few benefits: