Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI package #978

Merged
merged 13 commits into from Nov 23, 2022
Merged

Add UI package #978

merged 13 commits into from Nov 23, 2022

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 17, 2022

This adds a new package, @metamask/snaps-ui, which will provide Snaps with a way to construct user interfaces, as well as provide validation for those user interfaces.

The implementation is based on SIP-7.

Fixes #966

@Mrtenz Mrtenz force-pushed the mrtenz/ui-package branch 2 times, most recently from c60d7c6 to f3620ec Compare November 22, 2022 12:24
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #978 (ae0983b) into main (75596e0) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   92.67%   92.92%   +0.25%     
==========================================
  Files          93       96       +3     
  Lines        9224     9553     +329     
  Branches      894      903       +9     
==========================================
+ Hits         8548     8877     +329     
  Misses        676      676              
Impacted Files Coverage Δ
packages/snaps-ui/src/builder.ts 100.00% <100.00%> (ø)
packages/snaps-ui/src/nodes.ts 100.00% <100.00%> (ø)
packages/snaps-ui/src/validation.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Mrtenz Mrtenz marked this pull request as ready for review November 22, 2022 13:39
@Mrtenz Mrtenz requested a review from a team as a code owner November 22, 2022 13:39
packages/snaps-ui/.gitignore Outdated Show resolved Hide resolved
packages/snaps-ui/package.json Outdated Show resolved Hide resolved
packages/snaps-ui/src/builder.ts Outdated Show resolved Hide resolved
packages/snaps-ui/src/builder.ts Show resolved Hide resolved
@Mrtenz Mrtenz merged commit 3a827c6 into main Nov 23, 2022
@Mrtenz Mrtenz deleted the mrtenz/ui-package branch November 23, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement custom UI builder and underlying JSON representation
3 participants