Remove double logging in CLI #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
force-pushed
the
gr/clean-cli-errors
branch
from
1101593
to
d5ff8b0
Compare
GuillaumeRx
force-pushed
the
gr/clean-cli-errors
branch
from
395abaf
to
062dd3c
Compare
FrederikBolding
approved these changes
Nov 14, 2022
GuillaumeRx
force-pushed
the
gr/clean-cli-errors
branch
from
062dd3c
to
c5ddf51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the double logging in CLI by removing the
logErrormethod and throwing errors in handlers instead. Errors are already logged here.Fixes: #913