Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use controllers monorepo packages #955

Merged
merged 7 commits into from Nov 23, 2022
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 14, 2022

Use new @metamask/controllers monorepo packages instead of the previous monolithic package.

Fixes #954

@codecov-commenter
Copy link

Codecov Report

Merging #955 (d2bf62f) into main (4e63ed8) will not change coverage.
The diff coverage is 87.50%.

❗ Current head d2bf62f differs from pull request most recent head d3d1fe7. Consider uploading reports for the commit d3d1fe7 to get more accurate results

@@           Coverage Diff           @@
##             main     #955   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files          93       93           
  Lines        9224     9224           
  Branches      894      894           
=======================================
  Hits         8548     8548           
  Misses        676      676           
Impacted Files Coverage Δ
packages/rpc-methods/src/restricted/confirm.ts 0.00% <0.00%> (ø)
packages/rpc-methods/src/restricted/index.ts 0.00% <0.00%> (ø)
...c-methods/src/permitted/common/snapInstallation.ts 78.04% <100.00%> (ø)
packages/rpc-methods/src/permitted/requestSnaps.ts 90.44% <100.00%> (ø)
packages/rpc-methods/src/restricted/dialog.ts 98.37% <100.00%> (ø)
...ages/rpc-methods/src/restricted/getBip32Entropy.ts 100.00% <100.00%> (ø)
...es/rpc-methods/src/restricted/getBip32PublicKey.ts 93.97% <100.00%> (ø)
...ages/rpc-methods/src/restricted/getBip44Entropy.ts 100.00% <100.00%> (ø)
packages/rpc-methods/src/restricted/getEntropy.ts 100.00% <100.00%> (ø)
packages/rpc-methods/src/restricted/invokeSnap.ts 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@FrederikBolding FrederikBolding merged commit 24ed068 into main Nov 23, 2022
@FrederikBolding FrederikBolding deleted the fb/controllers-monorepo branch November 23, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new @metamask/controllers monorepo packages
3 participants