BREAKING: Refactor RPC method params and add tests #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david0xd
force-pushed
the
dd/rpc-method-params-refactoring
branch
from
060f80c
to
0b98939
Compare
david0xd
changed the title
david0xd
force-pushed
the
dd/rpc-method-params-refactoring
branch
from
91b70c2
to
81298b3
Compare
FrederikBolding
requested changes
Nov 11, 2022
FrederikBolding
changed the title
Fix jest conf after rebase Add manageState tests and refactor it Update jest config after rebase Add refactoring for invoke snap method Add some overall refactoring Refactor update state validation process and add more tests
david0xd
force-pushed
the
dd/rpc-method-params-refactoring
branch
from
9ba9781
to
4e0661f
Compare
FrederikBolding
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update the way of passing RPC method parameters.
All parameters will now be following the new convention where object-like named parameters are required.
All RPC methods that were accepting parameters as an array
[]are updated and appropriate tests are added.Updated are the following methods:
All of these mentioned and the rest of the untouched methods in this PR require a plain object structure
{}for passing parameters.Fixes: #870