Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Bump @metamask/key-tree to 6.0.0 #918

Merged
merged 1 commit into from Nov 7, 2022
Merged

BREAKING: Bump @metamask/key-tree to 6.0.0 #918

merged 1 commit into from Nov 7, 2022

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 7, 2022

@metmask/key-tree@6.0.0 has a few improvements:

  • All hexadecimal values always start with 0x.
  • The package does not use Buffer anymore.

This is breaking when working with [...]Buffer fields, as these have been renamed to [...]Bytes, and are now Uint8Arrays rather than Buffers. It does not affect typical usage using getBIP44AddressKeyDeriver.

@Mrtenz Mrtenz requested a review from a team as a code owner November 7, 2022 09:30
@FrederikBolding FrederikBolding merged commit fdd7032 into main Nov 7, 2022
@FrederikBolding FrederikBolding deleted the mrtenz/key-tree-6.0.0 branch November 7, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mrtenz @FrederikBolding