Added Permissions validation to SnapManifest #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
requested changes
Nov 5, 2022
ritave
force-pushed
the
ritave/validation
branch
from
357fac1
to
74c79ba
Compare
Mrtenz
requested changes
Nov 7, 2022
Mrtenz
reviewed
Nov 7, 2022
Mrtenz
previously approved these changes
Nov 7, 2022
ritave
force-pushed
the
ritave/validation
branch
2 times, most recently
from
cea9d74
to
e456f58
Compare
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
ritave
force-pushed
the
ritave/validation
branch
from
e456f58
to
2627edb
Compare
Mrtenz
requested changes
Nov 11, 2022
packages/snaps-execution-environments/src/common/BaseSnapExecutor.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+26
to
+28
| * wallet_enable / wallet_installSnaps permission typing. | ||
| * | ||
| * @deprecated This type is confusing and not descriptive, people confused it with typing initialPermissions, remove when removing wallet_enable. |
There was a problem hiding this comment.
Still used for in SnapControllers for now. Let's remove it in later PR.
Mrtenz
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.