Add transaction insight caveat for accessing transaction origin #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
reviewed
Nov 3, 2022
packages/controllers/src/snaps/endowments/transaction-insight.ts
Outdated
Show resolved
Hide resolved
FrederikBolding
force-pushed
the
fb/tx-insight-origin-caveat
branch
from
5239933
to
2c7ec1c
Compare
FrederikBolding
force-pushed
the
fb/tx-insight-origin-caveat
branch
from
a8024ef
to
75c80c0
Compare
Mrtenz
requested changes
Nov 15, 2022
packages/snaps-controllers/src/snaps/endowments/transaction-insight.test.ts
Outdated
Show resolved
Hide resolved
…sight.test.ts Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Mrtenz
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a transaction insight caveat that allows snaps to request access to the origin of a transaction.