Stop including snap state in controller state #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/stop-including-snap-state-in-state
branch
from
f8e3aa9
to
2aaf430
Compare
Mrtenz
requested changes
Oct 31, 2022
| @@ -188,14 +193,17 @@ type StoredSnaps = Record<SnapId, Snap>; | |||
|
|
|||
| export type SnapControllerState = { | |||
| snaps: StoredSnaps; | |||
| snapStates: Record<SnapId, string>; | |||
| // This type needs to be defined but is always empty in practice.. | |||
There was a problem hiding this comment.
Then why does it need to be defined? Can we just remove it?
Also:
Suggested change
| // This type needs to be defined but is always empty in practice.. | |
| // This type needs to be defined but is always empty in practice. |
There was a problem hiding this comment.
We want to persist snapStates, but not use it as controller state as that is synced with the extension UI. For us to be able to persist it, it has to be included in the SnapControllerState
FrederikBolding
force-pushed
the
fb/stop-including-snap-state-in-state
branch
from
027dd38
to
3bcfb49
Compare
Mrtenz
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops including snap state in controller state so it isn't piped to the extension UI. Instead it is stored with runtime information.