Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mm-snap init command #866

Merged
merged 30 commits into from Nov 4, 2022
Merged

Refactor mm-snap init command #866

merged 30 commits into from Nov 4, 2022

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Oct 25, 2022

Refactor mm-snap init command to fetch template from https://github.com/MetaMask/template-snap-monorepo. This also simplifies the init logic.

Fixes #803
Fixes #734

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner October 25, 2022 16:08
@GuillaumeRx GuillaumeRx marked this pull request as draft October 25, 2022 16:15
@GuillaumeRx GuillaumeRx changed the title Replace mm-snap init command template with template-snap-monorepo [WIP] Replace mm-snap init command template with template-snap-monorepo Oct 25, 2022
@GuillaumeRx GuillaumeRx marked this pull request as ready for review November 3, 2022 15:05
@GuillaumeRx GuillaumeRx changed the title [WIP] Replace mm-snap init command template with template-snap-monorepo Replace mm-snap init command template with template-snap-monorepo Nov 3, 2022
packages/cli/src/cmds/init/initHandler.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initHandler.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initHandler.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initHandler.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.test.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.ts Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.ts Outdated Show resolved Hide resolved
@socket-security
Copy link

socket-security bot commented Nov 4, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Non-existent author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Powered by socket.dev

packages/cli/src/cmds/init/initHandler.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.ts Outdated Show resolved Hide resolved
packages/cli/src/cmds/init/initUtils.ts Outdated Show resolved Hide resolved
packages/cli/src/test-utils/fs.ts Outdated Show resolved Hide resolved
@FrederikBolding
Copy link
Member

@GuillaumeRx This needs a rebase since another PR was just merged that changed package.json

Mrtenz
Mrtenz previously requested changes Nov 4, 2022
packages/cli/src/utils/snap-config.__GENERATED__.ts Outdated Show resolved Hide resolved
@FrederikBolding
Copy link
Member

@GuillaumeRx Please write a PR description that explains what this PR does.

@FrederikBolding
Copy link
Member

Something in the PR is broken, it creates infinite node processes

Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@GuillaumeRx GuillaumeRx changed the title Replace mm-snap init command template with template-snap-monorepo Refactor mm-snap init command Nov 4, 2022
@GuillaumeRx GuillaumeRx merged commit 8f7e2b4 into main Nov 4, 2022
@GuillaumeRx GuillaumeRx deleted the gr/replace-template-cli branch November 4, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants