Fix usage of wrong ethereum object for ethereum endowment
#1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
changed the title
ethereum object for ethereum endowment
Mrtenz
previously approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## main #1064 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 95 95
Lines 9922 9922
Branches 941 941
=======================================
Hits 9280 9280
Misses 642 642
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Mrtenz
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production we were accidentally using
globalThis.ethereuminstead of our limited EIP-1193 provider. This PR fixes that by moving an if-statement.