New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Use SIP-6 algorithm for state encryption #1055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
force-pushed
the
mrtenz/sip-6-state-encryption
branch
from
December 8, 2022 11:59
d5a9cde
to
1c90783
Compare
Codecov Report
@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
+ Coverage 94.13% 94.55% +0.42%
==========================================
Files 132 130 -2
Lines 4348 4336 -12
Branches 735 734 -1
==========================================
+ Hits 4093 4100 +7
+ Misses 255 236 -19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Mrtenz
force-pushed
the
mrtenz/sip-6-state-encryption
branch
from
December 14, 2022 13:19
602d80b
to
29be72b
Compare
Mrtenz
force-pushed
the
mrtenz/sip-6-state-encryption
branch
from
December 14, 2022 15:30
6d3a97a
to
819d655
Compare
FrederikBolding
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #944.
This changes the state encryption to use the algorithm as described in SIP-6 for deriving the encryption key. For this, I slightly refactored the
deriveEntropy
function to take amagic
value as extra parameter, and created a new magic value for state encryption.The encryption logic was moved to the
snap_manageState
JSON-RPC method.Breaking changes
SnapController
has changed: it no longer takes agetAppKey
parameter.