Hotfix for SnapLocation paths being wrongly normalized #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
ritave/hotfix
branch
from
3062c4d
to
10d00d2
Compare
ritave
commented
Dec 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
+ Coverage 93.50% 93.52% +0.02%
==========================================
Files 94 95 +1
Lines 9882 9922 +40
Branches 936 941 +5
==========================================
+ Hits 9240 9280 +40
Misses 642 642
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Mrtenz
reviewed
Dec 8, 2022
Mrtenz
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops prefixing paths internally with
./. It also adds SnapManifest coercing that normalizes the bundle and icon paths to be non-prefixed.