New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Use custom UI in snap_dialog
#1051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeRx
force-pushed
the
gr/use-custom-ui-dialog
branch
from
December 7, 2022 16:04
600269f
to
06705c8
Compare
GuillaumeRx
force-pushed
the
gr/use-custom-ui-dialog
branch
from
December 12, 2022 13:52
4763a4c
to
c875ee3
Compare
FrederikBolding
changed the title
Use custom UI in
BREAKING: Use custom UI in Dec 14, 2022
snap_dialog
snap_dialog
FrederikBolding
requested changes
Dec 14, 2022
GuillaumeRx
force-pushed
the
gr/use-custom-ui-dialog
branch
from
December 14, 2022 14:35
c875ee3
to
ad6ae23
Compare
FrederikBolding
previously approved these changes
Dec 14, 2022
Mrtenz
reviewed
Dec 15, 2022
GuillaumeRx
force-pushed
the
gr/use-custom-ui-dialog
branch
from
December 15, 2022 13:40
77c2401
to
c97ad6f
Compare
FrederikBolding
previously approved these changes
Dec 15, 2022
FrederikBolding
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
fields
param with acontent
param using Snaps custom UI.Prerequisite for MetaMask/metamask-extension#16522