Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Use custom UI in snap_dialog #1051

Merged
merged 14 commits into from Dec 15, 2022
Merged

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Dec 7, 2022

This replaces the fields param with a content param using Snaps custom UI.

Prerequisite for MetaMask/metamask-extension#16522

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #1051 (86b011b) into main (2ed41d3) will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   94.13%   95.70%   +1.56%     
==========================================
  Files         132       39      -93     
  Lines        4348     1769    -2579     
  Branches      735      292     -443     
==========================================
- Hits         4093     1693    -2400     
+ Misses        255       76     -179     
Impacted Files Coverage Δ
packages/rpc-methods/src/restricted/dialog.ts
packages/rpc-methods/src/restricted/index.ts
packages/snaps-ui/src/builder.ts
packages/rpc-methods/src/restricted/manageState.ts
packages/rpc-methods/src/restricted/getEntropy.ts
...ments/src/node-process/ChildProcessSnapExecutor.ts
packages/snaps-utils/src/mock.ts
packages/snaps-utils/src/cronjob.ts
packages/snaps-browserify-plugin/src/plugin.ts
...kages/rpc-methods/src/permitted/invokeSnapSugar.ts
... and 83 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@FrederikBolding FrederikBolding changed the title Use custom UI in snap_dialog BREAKING: Use custom UI in snap_dialog Dec 14, 2022
packages/rpc-methods/package.json Outdated Show resolved Hide resolved
packages/rpc-methods/package.json Outdated Show resolved Hide resolved
@GuillaumeRx GuillaumeRx merged commit 9463ae6 into main Dec 15, 2022
@GuillaumeRx GuillaumeRx deleted the gr/use-custom-ui-dialog branch December 15, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants