Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues with fetching snaps #1050

Merged
merged 3 commits into from Dec 7, 2022
Merged

Fix some issues with fetching snaps #1050

merged 3 commits into from Dec 7, 2022

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 7, 2022 •
edited

  • Uses fetchFunction for fetching of all snaps
  • Bind fallback fetch
  • Remove unused #npmRegistryUrl

@FrederikBolding FrederikBolding marked this pull request as ready for review December 7, 2022 17:30
@FrederikBolding FrederikBolding requested a review from a team as a code owner December 7, 2022 17:30
@FrederikBolding FrederikBolding merged commit 84937ac into main Dec 7, 2022
@FrederikBolding FrederikBolding deleted the fb/snap-fetch-fixes branch December 7, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FrederikBolding @Mrtenz