Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Use custom UI in transaction insights #1047

Merged
merged 4 commits into from Dec 14, 2022
Merged

BREAKING: Use custom UI in transaction insights #1047

merged 4 commits into from Dec 14, 2022

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 7, 2022 •
edited

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022 •
edited

Codecov Report

Merging #1047 (5da2347) into main (2ed41d3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         132      132           
  Lines        4348     4348           
  Branches      735      735           
=======================================
  Hits         4093     4093           
  Misses        255      255

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GuillaumeRx
Copy link
Contributor

You're missing {"path": "../snaps-ui/tsconfig.build.json"} in your tsconfig.build,json

@FrederikBolding FrederikBolding force-pushed the fb/allow-custom-ui-in-transaction-insights branch from 11c43c7 to b7ad29c Compare December 13, 2022 15:35
@FrederikBolding FrederikBolding changed the title Allow custom UI in transaction insights BREAKING: Allow custom UI in transaction insights Dec 13, 2022
@FrederikBolding FrederikBolding changed the title BREAKING: Allow custom UI in transaction insights BREAKING: Use custom UI in transaction insights Dec 13, 2022
@FrederikBolding FrederikBolding force-pushed the fb/allow-custom-ui-in-transaction-insights branch from 8a6b9a5 to dbb6561 Compare December 14, 2022 11:38
@FrederikBolding FrederikBolding marked this pull request as ready for review December 14, 2022 12:28
@FrederikBolding FrederikBolding requested a review from a team as a code owner December 14, 2022 12:28
Mrtenz
Mrtenz requested changes Dec 14, 2022
View reviewed changes
packages/snaps-utils/src/handlers.ts Outdated Show resolved Hide resolved
packages/snaps-utils/tsconfig.build.json Show resolved Hide resolved
@FrederikBolding @Mrtenz
Update packages/snaps-utils/src/handlers.ts
030aacc 
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Mrtenz
Mrtenz requested changes Dec 14, 2022
View reviewed changes
Copy link
Member

@Mrtenz Mrtenz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the example snap too (or create an issue to do it).

@FrederikBolding FrederikBolding merged commit 1fe00c8 into main Dec 14, 2022
@FrederikBolding FrederikBolding deleted the fb/allow-custom-ui-in-transaction-insights branch December 14, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FrederikBolding @codecov-commenter @GuillaumeRx @Mrtenz