Implement base UI types #1009
Merged
Implement base UI types #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
approved these changes
Nov 23, 2022
ritave
approved these changes
Nov 23, 2022
| * markdown string. | ||
| */ | ||
| export type Heading = Infer<typeof HeadingStruct>; | ||
|
|
||
| export const PanelStruct: Struct<Panel> = assign( | ||
| NodeStruct, | ||
| ParentStruct, | ||
| object({ | ||
| type: literal(NodeType.Panel), |
There was a problem hiding this comment.
You might want to restrict which kind of children are allowed in Panel.
For example, Panel probably shouldn't be able to contain other Panels.
There was a problem hiding this comment.
At some point we could allow panels to be either rows or columns for more customizability
There was a problem hiding this comment.
Is Panel a UI component with it's own border and design, or is it flow component that aligns it's children somehow without no UI design?
Because if it has a border, and you nest like 10 of those, it's going to look ugly.
There was a problem hiding this comment.
It currently has no design and is just a box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the base UI types
ParentandLiteral, in addition toNode.