Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder parameter for Prompt dialog #1007

Merged
merged 3 commits into from Nov 23, 2022

Conversation

GuillaumeRx
Copy link
Contributor

This adds a parameter to provide a placeholder for the input field on the Prompt type of snap_dialog

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner November 23, 2022 14:10
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #1007 (c8120c3) into main (7d5eede) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1007   +/-   ##
=======================================
  Coverage   92.94%   92.95%           
=======================================
  Files          96       96           
  Lines        9578     9590   +12     
  Branches      903      905    +2     
=======================================
+ Hits         8902     8914   +12     
  Misses        676      676           
Impacted Files Coverage Δ
packages/rpc-methods/src/restricted/dialog.ts 98.44% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GuillaumeRx GuillaumeRx merged commit 60762cd into main Nov 23, 2022
@GuillaumeRx GuillaumeRx deleted the gr/add-dialog-prompt-placeholder branch November 23, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants