Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger with Android devices that have declined permissions- Settings helper improvement #9601

Open
9 tasks
plasmacorral opened this issue May 10, 2024 · 0 comments
Labels
observation For observing issues that may or may not need fixing team-hardware-wallets type-enhancement New feature or request

Comments

@plasmacorral
Copy link
Contributor

What is this about?

When a user has previously failed to grant Location or Nearby device permissions, enhance the settings helper to take the user 2 menus deeper to clicks and take the user directly to where the need to make changes.

This is a continuation of an earlier bug report

On both Android 11 and 14, the settings helper directs users to the app settings (Settings>Apps>MetaMask) instead of directly to Settings>Apps>MetaMask>Permissions>Location for older devices or Settings>Apps>MetaMask>Permissions>Nearby devices for newer ones.

Recording:
Android 11

Scenario

Reproduction steps

  1. Ensure that Bluetooth device connection has been forgotten in the mobile OS settings
  2. Get a fresh install of MMM
  3. Configure MMM by importing an SRP
  4. From wallet view tap the account icon and follow the add hardware flow for Ledger
  5. When Location/Nearby device permissions are requested, decline/reject
  6. Reject Permissions a second time when asked again
  7. Notice error
  8. Tap CTA "View Settings"
  9. Note that user is brought to app level settings rather than into the Permissions Menu and the Permission in question (which depends on the API level of the device)

GIVEN a user has Bluetooth turned on
WHEN a user declines the Location/Nearby devices permissions prompt
AND a user attempts to pair a Ledger
THEN an error should be presented
AND the user should be helped into the menu directly to enable the permission required

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

When Bluetooth is turned on, but MMM does not have Location/Nearby Device permissions. The error message and helper button should bring the user to permission in question for the app, right now there are still 2 layers further the user must know to click thru.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
observation For observing issues that may or may not need fixing team-hardware-wallets type-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant